My opinion only: (I am not sure who has the final say on what goes in to Master)
On Mon, 5 Aug 2019 at 15:38, Curtis Dutton <[email protected]> wrote: A HAL_PORT pin allows for a writer component to send many bytes in one > operation to a reader component in real time. The PORT pins behave just > like any other pin in HAL and can be linked, unlinked etc... > > In addition to the modifications to make hal ports some other modifications > and new parts were required. > > halcompile.g - added port type. Also added (pin,param,variable)_ptr macros > to allow access to the actual pointer to those values. I think that these should go in together, as two commits in the same pull request. pyhal.py - similar to the other python component pyhal.py uses the ctypes > python library to interface with hal, which is significantly less code than > the halmodule.cc python wrapper that currently exists. > Is this necessary for the hal_port code to work? Is this a replacement for halmodule.cc or do we end up with both? I think that, unless it is an integral part of your hal_port, this should be a separate pull request and discussion. laserpower.comp - allows vector control of a laser, scaling power during a > move and has no limitations of number of joints a machine can have. > > raster.comp along with a python raster.py programming module to control the > raster, this allows control of the raster component from user space. > Standalone .comps should be no problem, I would roll these in with the main pull request, along with the tests. remapping of M codes to control the raster.py raster programming component. is this part of the sample configs? Or are you saying that you have made more M-codes remappable? Is this an enabler for, or an alternative to, the Mesa "datapainter"? -- atp "A motorcycle is a bicycle with a pandemonium attachment and is designed for the especial use of mechanical geniuses, daredevils and lunatics." — George Fitch, Atlanta Constitution Newspaper, 1916 _______________________________________________ Emc-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/emc-developers
