Vom: Mon, 2 Feb 2026 22:08:24 +0100

> It needs a bit more than TLC... There are many problems; off-by-one, 
> race conditions, buffer overruns, static buffers and other non-reentrant 
> code, possible leaks, etc... And then, the source compiles as a C++ 
> program, but the code is really written as C.

Indeed. As mentioned in the PR, I experimented with a version that uses libcli 
for parsing: 
https://github.com/LinuxCNC/linuxcnc/compare/master...heeplr:linuxcnc:linuxcncrsh-libcli

There probably are even better solutions.

 
> At least I can look at the test(s) and see how good/bad my changes are 
> so far.
> 

A (working) PR to cleanup some stuff in linuxcncrsh would certainly be 
appreciated. ;-)


Best regards
-- 
  Daniel 


_______________________________________________
Emc-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/emc-developers

Reply via email to