Yoni Rabkin (2016-11-27 17:12 -0500) wrote: > Alex Kost <[email protected]> writes: > >> Yoni Rabkin (2016-10-30 09:27 -0400) wrote: >> >>> Alex Kost <[email protected]> writes: >>> >>>> Yoni Rabkin (2016-10-24 21:42 -0400) wrote: >>>> >>>>> In 4.2 I want emms-print-metadata to be installed by `make install', >>>>> just like the manual says it is. >>>>> >>>>> As far as I can tell emms-print-metadata isn't being installed into >>>>> /usr/bin/ by `make install'. Can people confirm this? >>>> >>>> I confirm, also 'make' doesn't build emms-print-metadata, because it is >>>> not specified in "all" target. >>> >>> Thank you for this. >>> >>> I've fixed this and it will be released along with version 4.2 in >>> November. >> >> I see that you didn't add 'emms-print-metadata' to 'all' target in >> commit cbbe098¹, so "make" still doesn't build it. Was it intentional? > > Yes. At this point we still want to keep the make phase to be about > elisp. This should be resolved when we decide how to do the compilation > in way compatible with remotely installable elisp packages.
Sorry, I don't understand; do you mean installation from ELPA? But it doesn't care about Makefile at all, so I don't see what problem can be caused by adding 'emms-print-metadata' to 'all' target. >> Also you use: >> >> install -m 755 $(SRCDIR)/emms-print-metadata $(BINDIR)/emms-print-metadata; >> >> This will fail if BINDIR does not exist (this is the case for such >> systems as GuixSD or NixOS). Could you please also add "-D" flag to >> "install" command? > > Do you have access to those systems? Can you do a test to see that it > would work as intended and send a patch? Yes, I can confirm (I use GuixSD and I am one of the Guix contributors), but after all it's not a big thing. It's one of the several (small) issues with the EMMS Makefile that we make workarounds for in our emms package: the same problem happens with "man" directory (Makefile also assumes it exists), also info manual is put in "$(PREFIX)/info" instead of "$(PREFIX)/share/info". To recap, it is fixed on the Guix side, so you may ignore this message :-) If you (or someone who is reading) are interested: GNU Guix¹ is a package manager and GuixSD is a system thereof. It uses Guile programming language, so people who like sexps may like it too :-) And here is how EMMS package is defined (it is quite complex though comparing with most packages): <http://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/emacs.scm#n897> ¹ https://www.gnu.org/software/guix/ -- Alex _______________________________________________ Emms-help mailing list [email protected] https://lists.gnu.org/mailman/listinfo/emms-help
