Daniel Semyonov <[email protected]> writes: >>>>>> Yoni Rabkin writes: > > > No API-key needed either; that's nice. I don't see a reason not to > > include it. Please go ahead. > > Great! > > > Please make sure it compiles cleanly on recent Emacs versions (such as > > 29.4) > > I just tested this and it compiles with no warnings.
Wouldn't it fail if Emacs is compiled without native json parsing (--with-json)? > > and that there is some documentation added to doc/emms.texinfo > > I actually already did that but forgot to include it in the patch I > sent, basically just added a bit to the existing Lyrics node as there is > only one user facing function and one user option added. > BTW, I noticed there is no documentation of > 'emms-track-initialize-functions', after adding my patch the only > appearance of this variable in the manual will be under the Lyrics node. > > > Thank you for your work. > > Thank you for maintaining a great piece of software, > Daniel > -- "Cut your own wood and it will warm you twice"
