>>>>> Yoni Rabkin writes:
> Daniel Semyonov <[email protected]> writes:
>>>>>>> Yoni Rabkin writes:
>>
>> > Daniel Semyonov <[email protected]> writes:
>> >>>>>>> Yoni Rabkin writes:
>> >> > Wouldn't it fail if Emacs is compiled without native json parsing
>> >> > (--with-json)?
>> >>
>> >> Oh sorry, I didn't think to test that, I'll do that when I get home.
>>
>> > There is nothing wrong with adding a feature to Emms which requires a
>> > compile-time option, but we would need to make sure that the feature
>> > deals with that option's absence gracefully.
>>
>> No worries, I added (and tested) support for parsing without JSON if not
>> available; it's fairly simple to do in this case.
>> Also pushed a small fix to the documentation I added.
>>
>> Daniel
>>
> Excellent; thank you. I guess all that is missing is something like this
> for all missing functions:
> (eval-when-compile
> (declare-function json-parse-buffer "json.c"))
Yes, now done, it's amazing how easy it is to forget all the little
details after taking a short break from development.
(I also mistakenly added '(require 'subr-x)' before realizing it
actually isn't needed for this file, and was a bit too quick to push the
first commit, sorry about that, I pushed another commit removing it; I
could've sworn 'if-let*' and friends were defined there)
Daniel
