----- Original Message ----- > From: "Yair Zaslavsky" <yzasl...@redhat.com> > To: "Allon Mureinik" <amure...@redhat.com> > Cc: "Moti Asayag" <masa...@redhat.com>, "Oved Ourfalli" <ov...@redhat.com>, > "engine-devel" <engine-devel@ovirt.org> > Sent: Tuesday, January 7, 2014 7:07:48 AM > Subject: Re: [Engine-devel] IMPORTANT: FindBugs threshold update > > > > ----- Original Message ----- > > From: "Allon Mureinik" <amure...@redhat.com> > > To: "Moti Asayag" <masa...@redhat.com> > > Cc: "Yair Zaslavsky" <yzasl...@redhat.com>, "Oved Ourfalli" > > <ov...@redhat.com>, "engine-devel" > > <engine-devel@ovirt.org> > > Sent: Monday, January 6, 2014 6:44:48 PM > > Subject: Re: [Engine-devel] IMPORTANT: FindBugs threshold update > > > > > > > > ----- Original Message ----- > > > From: "Moti Asayag" <masa...@redhat.com> > > > To: "Yair Zaslavsky" <yzasl...@redhat.com> > > > Cc: "Oved Ourfalli" <ov...@redhat.com>, "engine-devel" > > > <engine-devel@ovirt.org> > > > Sent: Thursday, January 2, 2014 11:46:29 AM > > > Subject: Re: [Engine-devel] IMPORTANT: FindBugs threshold update > > > > > > > > > > > > ----- Original Message ----- > > > > From: "Yair Zaslavsky" <yzasl...@redhat.com> > > > > To: "Moti Asayag" <masa...@redhat.com> > > > > Cc: "Oved Ourfalli" <ov...@redhat.com>, "Eyal Edri" <ee...@redhat.com>, > > > > "engine-devel" <engine-devel@ovirt.org> > > > > Sent: Thursday, January 2, 2014 11:12:17 AM > > > > Subject: Re: [Engine-devel] IMPORTANT: FindBugs threshold update > > > > > > > > > > > > > > > > ----- Original Message ----- > > > > > From: "Moti Asayag" <masa...@redhat.com> > > > > > To: "Oved Ourfalli" <ov...@redhat.com>, "Eyal Edri" > > > > > <ee...@redhat.com> > > > > > Cc: "engine-devel" <engine-devel@ovirt.org> > > > > > Sent: Thursday, January 2, 2014 12:08:43 AM > > > > > Subject: Re: [Engine-devel] IMPORTANT: FindBugs threshold update > > > > > > > > > > > > > > > > > > > > ----- Original Message ----- > > > > > > From: "Oved Ourfalli" <ov...@redhat.com> > > > > > > To: "engine-devel" <engine-devel@ovirt.org>, "Allon Mureinik" > > > > > > <amure...@redhat.com>, "Alissa Bonas" > > > > > > <abo...@redhat.com> > > > > > > Sent: Wednesday, January 1, 2014 4:25:50 PM > > > > > > Subject: [Engine-devel] IMPORTANT: FindBugs threshold update > > > > > > > > > > > > Hi all, > > > > > > > > > > > > Up until now the jenkins jobs on the gerrit patches included a > > > > > > findbugs > > > > > > job, > > > > > > that failed only in case of a warning of level NORMAL or higher. > > > > > > Now we update this threshold to fail on any findbugs warning, > > > > > > including > > > > > > LOW > > > > > > ones. > > > > > > > > Moti - > > > > 1. Aren't use running a local jenkins instance on one of your hosts? > > > > Maybe > > > > Eyal can publish the findbugs job? > > > > > > Well...that server is on maintenance for quite a while... > > > > > > > 2. What about running the findbugs UI? I find it kinda handy... > > > > > > The findbugs UI expects the xml created by findbugs with all of the > > > violations. > > > The question is how those violation are created ? where are the rules by > > > which > > > findbugs verifies the code (can be findbugs jar or jenkins findbugs > > > plugin > > > or > > > other...). > > > > > > Currently by running 'mvn findbugs:findbugs' i don't get a a single xml > > > aggregating > > > all of the violations and the produced ones contain a lot of warnings. > > > > > > So I'd like to know how can i be able to run this test locally ? > > You're missing the profile with the project's exclusions. > > What you'd want to do is probably this: > > mvn findbugs:check -Pfindbugs-general > > > > This way you won't have to go over any report, you will just fail the build > > if you introduce a regression. > > > Thanks Allon, > This worked - however - you get a full textual description of the "bug" and > not the code. > In some cases one may want to filter out a specific bug report, so the "bug > code" is important. > Do you know by any chance how to produce this using mvn findbugs ? > > Yair What I usually do is mvn findbugs:findbugs -Pfindbugs-general
This will create an xml report under each module's target/site folder with all the details you may need in order to exclude the resulting bug. Having said that, if you need to add an exclusion, there's a better-than-fair chance you're going the wrong way. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Could you provide instructions of running findbugs locally and how to > > > > > evaluate > > > > > the result the same as done by the jenkins job ? > > > > > > > > > > > Please make sure to rebase your current patches and check that the > > > > > > findbugs > > > > > > job finish successfully. > > > > > > It will probably fail without a rebase, as the last patches > > > > > > clearing > > > > > > the > > > > > > warnings were merged a few hours ago. > > > > > > > > > > > > Kodus to everyone involved in clearing all the LOW level > > > > > > warnings... > > > > > > mostly > > > > > > Allon and Alissa, but others helped as well! :-) > > > > > > > > > > > > > > > > Well done! > > > > > > > > Great news - good work guys! > > > > > > > > > > > > > > > Cheers, > > > > > > Oved > > > > > > _______________________________________________ > > > > > > Engine-devel mailing list > > > > > > Engine-devel@ovirt.org > > > > > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > > > > > > > > > _______________________________________________ > > > > > Engine-devel mailing list > > > > > Engine-devel@ovirt.org > > > > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > > > > > > > > > > _______________________________________________ > > > Engine-devel mailing list > > > Engine-devel@ovirt.org > > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > > > > _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel