Michael Kublin has posted comments on this change.
Change subject: core: Add Task Manager Default Command Monitoring
......................................................................
Patch Set 3: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java
Line 53: job.setStartTime(new Date());
I don't get it here you passed JobReposotory to Job
Line 110:
Why create monitoringContext if job is not monitored? If every command is
monitored the check is abused.
Line 119: Job job = createJob(actionType, command);
Here you using JobRepository to save Job. Why pass JobRepository ?
Line 261: if (context.shouldEndJob()) {
Why we are retrieving jobs from DB here ?
Why not same transaction ?
--
To view, visit http://gerrit.ovirt.org/1089
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a0ee368f63ec5bdf54ef18072a45fe8f01acbde
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
