Michael Kublin has posted comments on this change. Change subject: core: Task Manager Add Default Command Monitoring ......................................................................
Patch Set 7: (2 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java Line 108: */ and what we are doing in ExecutioContext.prepareCommand ? .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java Line 155: Like I said, if u creating here don't create inside commandBase, if u need it at other place use other method, there are no reason to create an unused object and after a second force JVM to remove them. -- To view, visit http://gerrit.ovirt.org/1089 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a0ee368f63ec5bdf54ef18072a45fe8f01acbde Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
