Michael Kublin has posted comments on this change.
Change subject: engine: Add Quota helper class
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QuotaHelper.java
Line 24: public class QuotaHelper {
Sorry, but new Long(1) or 1L will work fine, to use string is stupid
Line 32:
This is not singelton, this is anti pattern, just do static initialization of
vriable
--
To view, visit http://gerrit.ovirt.org/1327
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie67aad0501bbec91e47740e536eb371b62f42d44
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
