Jonathan Choate has posted comments on this change. Change subject: engine-core: Move disk command ......................................................................
Patch Set 2: (2 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskValidator.java Line 8: The intent is indeed to use this in other places. The other purpose is proper separation of concerns. The command classes should know what needs to be checked. They represent the workflow rules. But, they do not need to be concerned with the "how" of the checks. By extracting the mechanics we can centralize the logic of the how and also make the command classes much less likely to need to change as the internals change. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java Line 68: storage_domains domain = entry.getValue(); You would be amazed at how many places in the code we do this cast when related to disk size. I believe that the argument is that when checking disk capacity the loss in precision is negligible. -- To view, visit http://gerrit.ovirt.org/1608 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e3eddcf7b00c65440eac76f141de1e5ba83c675 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jonathan Choate <[email protected]> Gerrit-Reviewer: Jonathan Choate <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
