Michael Kublin has posted comments on this change. Change subject: engine-core: Move disk command ......................................................................
Patch Set 2: (3 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskValidator.java Line 8: Approach is ok, as for me. Line 13: Better pass DiskImage at contractor and not diskImageId. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java Line 68: storage_domains domain = entry.getValue(); The problem is not precision, the problem is when double > Integer.MAX_VALUE. Hope we will never force such problem. But precision also can be important, because of here we actually sum size of different disk, and difference can be big. But, like I said is not related to that commit -- To view, visit http://gerrit.ovirt.org/1608 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e3eddcf7b00c65440eac76f141de1e5ba83c675 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jonathan Choate <[email protected]> Gerrit-Reviewer: Jonathan Choate <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
