Mike Kolesnik has posted comments on this change. Change subject: core: db scripts for removing disk image template ......................................................................
Patch Set 2: (4 inline comments) See comments. This patch will break the functionality/build? .................................................... File backend/manager/dbscripts/create_views.sql Line 107: FROM image_vm_map LEFT JOIN Why change to left join? Line 109: LEFT JOIN disk_image_dynamic ON images_storage_domain_view.image_guid = disk_image_dynamic.image_id; Same, why change to left join? .................................................... File backend/manager/dbscripts/images_sp.sql Line 91: Create or replace FUNCTION GetImageByVmIdAndImageId(v_vm_guid UUID, v_image_guid UUID) RETURNS SETOF vm_images_view Why is this query needed if image_id is already a PK? .................................................... File backend/manager/dbscripts/upgrade/03_01_0260_remove_image_templates_table.sql Line 3: create or replace FUNCTION fn_tmp_add_default_disk_image() No need to write a function since we decided that upgrade is not a re-entrant process.. -- To view, visit http://gerrit.ovirt.org/1565 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If83885966ca8c187351623acbe502cb6ce218e2a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
