Omer Frenkel has posted comments on this change. Change subject: core: DO NOT SUBMIT db scripts for removing disk image template ......................................................................
Patch Set 3: Looks good to me, but someone else must approve (1 inline comment) .................................................... File backend/manager/dbscripts/upgrade/03_01_0290_remove_image_templates_table.sql Line 3: create or replace FUNCTION fn_tmp_add_default_disk_image() not sure if you need the function, i think the code can be just executed. -- To view, visit http://gerrit.ovirt.org/1565 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If83885966ca8c187351623acbe502cb6ce218e2a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
