Yair Zaslavsky has posted comments on this change.
Change subject: core: Add Task Manager Queries
......................................................................
Patch Set 3: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetJobsByOffsetQuery.java
Line 50: List<Job> jobs =
DbFacade.getInstance().getJobDao().getJobsByOffsetAndPageSize(offset *
pageSize, pageSize);
Question - don't you think it will be More efficient if JobDAO implements
SearchDAO and you will run some search query on db?
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryParametersBase.java
Line 4:
Theses change look like a cleanup to me, why not have them in a separate
cleanup patch?
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/JobDaoDbFacadeImpl.java
Line 108: return
getCallsHandler().executeReadList("GetJobsByCorrelationId",
createEntityRowMapper(), parameterSource);
is this method using the same instane for mapper or results?:)
--
To view, visit http://gerrit.ovirt.org/1742
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I17fb87e87fc90b7443596111111cd70ae7889d98
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
