Moti Asayag has posted comments on this change.
Change subject: core: Add Task Manager Queries
......................................................................
Patch Set 3: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetJobsByOffsetQuery.java
Line 50: List<Job> jobs =
DbFacade.getInstance().getJobDao().getJobsByOffsetAndPageSize(offset *
pageSize, pageSize);
Implementing the SeachDao isn't the problem here, the issue is if we want the
Tasks to be searchable and implementing the query language for tasks.
Tasks (Jobs) are designed to be presented in a sub-tab therefore not search
isn't required for them.
As the feature evolve this could be re-examine.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryParametersBase.java
Line 4:
Correct. One squash too many - will separate it to its own patch.
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/JobDaoDbFacadeImpl.java
Line 108: return
getCallsHandler().executeReadList("GetJobsByCorrelationId",
createEntityRowMapper(), parameterSource);
Correct. Will modify it.
--
To view, visit http://gerrit.ovirt.org/1742
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I17fb87e87fc90b7443596111111cd70ae7889d98
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
