Omer Frenkel has posted comments on this change.
Change subject: engine-core: Prestarted Vm (2 - Review Only)
......................................................................
Patch Set 4: (5 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java
Line 109: setVm(DbFacade.getInstance().getVmDAO().getById(getVmId()));
when getVmId() won't return null/empty?
Line 169:
please remove spaces here
Line 189: if
(DbFacade.getInstance().getDiskImageDAO().getAllStatelessVmImageMapsForVm(getVm().getvm_guid()).size()
> 0) {
isnt this code is done already inside runVm?
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachUserFromVmFromPoolCommand.java
Line 65: private void RestoreVmFromBaseSnapshot(VM vm) {
i think there should be a call to RestoreStatelessVmCommand
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromPoolCommand.java
Line 48: if (getVmPoolId() != null) {
not good, if the vm has stateless images, we dont want to forget about them,
specially, it probably means the vm is attached to a user...
--
To view, visit http://gerrit.ovirt.org/1798
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3c0b0d69c0da82d3ba2dcbcf045cd92a6db7bef
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
