Muli Salem has posted comments on this change.
Change subject: engine-core: Prestarted Vm (2 - Review Only)
......................................................................
Patch Set 6: (9 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java
Line 111: boolean isPrestartedVm = false;
Improved queries inside the lock.
Line 112: synchronized (_lockObject) {
Done
Line 113:
setVmId(getPrestartedVmToAttach(getParameters().getVmPoolId()));
Done
Line 164: // (since 'Vm' is dependant on 'mVmId', which is not set
here).
Done
Line 171:
We reach this method before the endAction() if RunVmCommand.
Line 172: if
(DbFacade.getInstance().getDiskImageDAO().getAllStatelessVmImageMapsForVm(getVm().getvm_guid()).size()
> 0) {
It is only called here.
Line 202: // (since 'Vm' is dependant on 'mVmId', which is not set
here).
Done
Line 206: // the DB so we won't get a log-deadlock because of the
transaction.
Done
Line 208:
No, we need to call it explicitly.
--
To view, visit http://gerrit.ovirt.org/1798
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3c0b0d69c0da82d3ba2dcbcf045cd92a6db7bef
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
