Yair Zaslavsky has posted comments on this change.
Change subject: core: DO NOT SUBMIT BLL: Using DiskImage instead of DiskImage
template
......................................................................
Patch Set 7: (19 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
Line 504:
Done
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromScratchCommand.java
Line 102: return (disks.size()>0) ?
ConcreteAddVmImages(disks.get(0).getId()): true;
Done
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java
Line 108: _diskImage = (tmpImage == null ||
tmpImage.getVmEntityType() == VmEntityType.TEMPLATE)?(null):(tmpImage);
I will try to check this issue later. You might be right, I think we should so
some serious thinking.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateImageTemplateCommand.java
Line 61: newImage.setVmEntityType(VmEntityType.TEMPLATE);
Done
Line 84: image_vm_map imageVmMap = new
image_vm_map(true,newImage.getId(),getImageContainerId());
Done
Line 88: // 1. as vtmid_guid
Done
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotFromTemplateCommand.java
Line 36: .getDiskImageDAO().get(getImageId());
You may be right. I will check this issue with the issue of
BaseImagesCommand.getDIskImage
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmTemplatesDisksQuery.java
Line 21: return
DbFacade.getInstance().getDiskImageDAO().getAllForVm(getParameters().getId());
Done
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
Line 63: private Map<Guid,Guid> imageToDestinationDomainMap = new
HashMap<Guid, Guid>();
Done
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java
Line 50: public Map<Guid,Guid> imageToDestinationDomainMap = new
HashMap<Guid, Guid>();
Done
Line 320: image_vm_map imageVmMap = new
image_vm_map(image.getactive(),image.getId(),image.getvm_guid());
Done
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyImageGroupCommand.java
Line 73: if (_diskImage == null) {
I think BaseImagesCommand.getDiskIMage behavior did not suit it here, another
reason why to revisit its behavior
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmTemplateImageTemplatesCommand.java
Line 84: image_vm_map_id imageVmMap = new
image_vm_map_id(diskImage.getId(),diskImage.getvm_guid());
Done
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveTemplateSnapshotCommand.java
Line 61: protected DiskImage getDiskImage() {
Trying to override here the basic behavior of BaseImagesCommand.getDiskImage -
I think that in this case it was not a good flow. I will investigate all of
this, as we discussed.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetStorageDomainsByVmTemplateIdQuery.java
Line 58:
Done (will also clean old junk)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateCommand.java
Line 92: List<DiskImage> vmtImages = DbFacade.getInstance()
Done
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateHandler.java
Line 48: vmt.getDiskList().add(dit);
True, once again, a "conservative" translation.
I change this.
Line 67: public static java.util.ArrayList<DiskImage>
GetDiskImageListByDiskImageTemplateList(VmTemplate vmTemplate,
Done
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/BasicTestSetup.java
Line 201: "",VmEntityType.VM);
Done
--
To view, visit http://gerrit.ovirt.org/1570
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I701bc85d005e3b1636feb8cb6cedca099356614c
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
