Mike Kolesnik has posted comments on this change.
Change subject: core: DO NOT SUBMIT BLL: Using DiskImage instead of DiskImage
template
......................................................................
Patch Set 8: (9 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java
Line 250
Why did you remove the not?!
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java
Line 324: VmDeviceType.DISK, VmDeviceType.DISK, "",
true, false);
Please format this code with formatter
Line 327: image_vm_map imageVmMap = new
image_vm_map(true,image.getId(),image.getvm_guid());
Please format this code with formatter
Line 339
Why delete newline?
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyImageGroupCommand.java
Line 39: _diskImage = (diskImages.isEmpty()) ?
null:diskImages.get(0);
Please format this code with formatter
Line 48: /* YAIR
Why keep commented out code?
Line 94: getImage().
Why move the dot?
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmTemplateImageTemplatesCommand.java
Line 84: DbFacade.getInstance().getImageVmMapDAO().remove(new
image_vm_map_id(diskImage.getId(),diskImage.getvm_guid()));
Please format this code with formatter
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveTemplateSnapshotCommand.java
Line 61: protected DiskImage getDiskImage() {
Why keep commented code?
--
To view, visit http://gerrit.ovirt.org/1570
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I701bc85d005e3b1636feb8cb6cedca099356614c
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
