Omer Frenkel has posted comments on this change.

Change subject: engine: Add permission support for Quota consume
......................................................................


Patch Set 5: (2 inline comments)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QuotaHelper.java
Line 74:     public static void addQuotaPermission(List<PermissionSubject> 
quotaPermissionList, storage_pool storagePool, Guid quotaId) {
maybe call it addQuotaPermissionSubject, as it doesn't add permission..

Line 76:             log.debug("Adding validation for quota consume to 
permission list");
"Adding validation for consume quota to permission subjects list"

--
To view, visit http://gerrit.ovirt.org/2108
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7311edd8fadeffcea920e2e0eac02496f3d6e0c7
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to