Livnat Peer has posted comments on this change. Change subject: engine: Add permission support for Quota consume ......................................................................
Patch Set 6: (3 inline comments) >From this patch it is not obvious why you need addQuotaPermissionSubject both >in QuotaHelper and in QuotaManager? .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QuotaHelper.java Line 73: please return the list as output parameter, changing the input parameters instead of using return value is not a good practice IMO. .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QuotaManager.java Line 61: please return the list as output parameter, changing the input parameters instead of using return value is not a good practice IMO. .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java Line 98: import org.springframework.jdbc.core.JdbcTemplate; why is this file part of the patch? -- To view, visit http://gerrit.ovirt.org/2108 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7311edd8fadeffcea920e2e0eac02496f3d6e0c7 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
