Maor Lipchuk has posted comments on this change.
Change subject: engine: Add/Edit quota commands
......................................................................
Patch Set 11: (6 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddQuotaCommand.java
Line 23: setStoragePoolId(parameters.getStoragePoolId());
Agreed, I changed the quota parameters to be inherited from
VdcActionParametersBase.
I also set the storage pool id only at setQuotaParameter() method.
Line 28: if (getParameters() == null) {
Agreed, removed the check, and changed it to be only one command sentance.
Line 34: return true;
See previous answer
Line 45: public Map<Guid, VdcObjectType> getPermissionCheckSubjects() {
Changed to validate only on storage pool permission
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateQuotaCommand.java
Line 13: public class UpdateQuotaCommand<T extends QuotaCRUDParameters> extends
CommandBase<T> {
Agreed changed
Line 28: if (getParameters() == null) {
I think the validation should be in the commandsFactory as you suggested before
--
To view, visit http://gerrit.ovirt.org/2084
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4abf8bab03b8044e11f1e0a07dbb01e3b0fd8e32
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
