Omer Frenkel has posted comments on this change. Change subject: engine: Add/Edit quota commands ......................................................................
Patch Set 13: (4 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddQuotaCommand.java Line 27: return (!QuotaHelper.getInstance().checkQuotaValidationForAddEdit(getParameters().getQuota(), why you return not of the check? IIRC it will return true if quota is valid, and then you should return true for the CDA Line 40: return Collections.singletonMap(getStoragePoolId() == null ? null : getStoragePoolId().getValue(), getStoragePoolId will always return null as it is only set in the execute which happens after this code runs .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateQuotaCommand.java Line 22: setStoragePoolId(getParameters().getQuota() != null ? getParameters().getQuota().getStoragePoolId() : null); this line exactly is missing in addQuotaCommand ctor Line 35: // TODO : Add why not just implement it? -- To view, visit http://gerrit.ovirt.org/2084 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4abf8bab03b8044e11f1e0a07dbb01e3b0fd8e32 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
