Eli Mesika has posted comments on this change.
Change subject: core: enable null values for monitor, CD , Floppy is_plugged
property
......................................................................
Patch Set 1: (4 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDevice.java
Line 29: private Guid deviceId;
Done
Line 69: private Boolean isPlugged = false;
The isPlugged must be 3-state , NULL should be checked in each place separately
Line 169: this.specParams =
VmDeviceCommonUtils.appendDeviceIdToSpecParams(this.getId().getDeviceId(),
this.specParams);
Done
Line 185: public Boolean getIsPlugged() {
Got it , will fix in future
--
To view, visit http://gerrit.ovirt.org/2408
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I826868106b7f27581838e96a985dbdeda4fa6aa2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
