Moti Asayag has posted comments on this change.
Change subject: core: enable null values for monitor, CD , Floppy is_plugged
property
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
Line 131: public static void addManagedDevice(CompensationContext
ctx,VmDeviceId id, VmDeviceType type, VmDeviceType device, String specParams,
boolean is_plugged, boolean isReadOnly) {
Sorry for getting back to this file, but i don't think the compensation context
should be assigned here, if you move it from here and return value of
managedDevice, each method caller can decide if to keep a snapshot of it.
By removing the BLL dependency from it, you can move this class to VdsBroker
project and merge it with the other util class if you don't want to have 2
separate files (1 in utils, 1 in vdsBroker).
--
To view, visit http://gerrit.ovirt.org/2408
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I826868106b7f27581838e96a985dbdeda4fa6aa2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
