Doron Fediuck has posted comments on this change.
Change subject: DO NOT SUBMIIT - wip - core: gluster bootstrap
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File backend/manager/conf/vds_installer.py
Line 230: execfn += ["-g"]
You are changing the original order of the arguments,
by starting with them. Are you sure this will not affect the script?
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsInstaller.java
Line 124: _bootStrapInitialCommand =
_bootStrapInitialCommand.replace("-g", "");
1. This is a bug, since it'll replace /any/ '-g' in the string, including other
stuff. So what you need is to use ' -g ' (spaces), or a pattern like the code
is using {g-dummy}.
2. Are you not missing another line for '-v'?
--
To view, visit http://gerrit.ovirt.org/2503
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I35bf9475e713ab9cc571800e4abc38d4076937d7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
