Oved Ourfali has posted comments on this change.

Change subject: DO NOT SUBMIIT - wip - core: gluster bootstrap
......................................................................


Patch Set 2: (2 inline comments)

....................................................
File backend/manager/conf/vds_installer.py
Line 230:                 execfn += ["-g"]
Indeed.
I tested it and it ran okay, as the logic is not order-sensitive for the 
options. The order is important only after the options.

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsInstaller.java
Line 124:         _bootStrapInitialCommand = 
_bootStrapInitialCommand.replace("-g", "");
1. Will do.
2. For now no (as we only support virt). But, when doing "1" then we will have 
to add a line substituting -v {v-dummy} with -v.

--
To view, visit http://gerrit.ovirt.org/2503
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35bf9475e713ab9cc571800e4abc38d4076937d7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to