Moti Asayag has posted comments on this change.
Change subject: core: prevent attaching a non-VM-network on old clusters
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachNetworkToVdsGroupCommand.java
Line 117: &&
getVdsGroup().getcompatibility_version().compareTo(Version.v3_1) >= 0) {
It is safer to use the constant first for the comparison (reduces risk of NPE
from getVdsGroup().getcompatibility_version()) or the need to check if null.
e.g.
Version.v3_1.compareTo(getVdsGroup().getcompatibility_version()) < 0
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
Line 540: NON_VM_NETWORK_NOT_SUPPORTED_FOR_POOL_LEVEL;
Shouldn't this be added also to frontend ? See
http://www.ovirt.org/wiki/Engine_Adding_Messages
--
To view, visit http://gerrit.ovirt.org/2549
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3c272d621a3c2036dde1ed2a120cbfb5d71903
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
