Roy Golan has posted comments on this change.
Change subject: core: prevent attaching a non-VM-network on old clusters
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachNetworkToVdsGroupCommand.java
Line 117: &&
getVdsGroup().getcompatibility_version().compareTo(Version.v3_1) >= 0) {
I think its less readable here and more important clusters should always be
with compatibility version so if there is one with no value thats a bug and its
not so bad to fail with NPE here as it will serve as protection from other bad
stuff happenning
--
To view, visit http://gerrit.ovirt.org/2549
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf3c272d621a3c2036dde1ed2a120cbfb5d71903
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
