Michael Pasternak has posted comments on this change.
Change subject: RDSL parameters fixs:
......................................................................
Patch Set 2: (9 inline comments)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
Line 34
notice you deleted the right signature and left wrong.
Line 56: vm.os.kernel: xs:string
white space
Line 609: optionalArguments: {cluster.name: 'xs:string',
cluster.description: 'xs:string', cluster.cpu.id: 'xs:string',
cluster.version.major: 'xs:int', cluster.version.minor: 'xs:int',
not sure about cpu and version, does they realy updatable?
Line 621: optionalArguments: {cluster.description: 'xs:string',
cluster.cpu.id: 'xs:string', cluster.version.major: 'xs:int',
cluster.version.minor: 'xs:int',
cpu & version are mandatory afair
Line 663
is there other signature for this URI?
Line 694
why did you removed headers from this signature?
Line 715: case_sensitive: {context: matrix, type: 'xs:boolean', value:
true|false, required: false}
looks like this urlparams not relevant fot this signature
Line 725: datacenter.storage_format: xs:string
where is urlparams ?
Line 1206: hostnic.name: xs:string
not sure name is updatable
--
To view, visit http://gerrit.ovirt.org/2619
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c42f9d38b279071a98cc9414a0abba8e532df80
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: [email protected]
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: [email protected]
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
