[email protected] has posted comments on this change.
Change subject: RDSL parameters fixs:
......................................................................
Patch Set 2: (7 inline comments)
thanks for the comments, see my responses in line. Sending patch with changes
shortly
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
Line 609: optionalArguments: {cluster.name: 'xs:string',
cluster.description: 'xs:string', cluster.cpu.id: 'xs:string',
cluster.version.major: 'xs:int', cluster.version.minor: 'xs:int',
>From what I can tell by looking at UpdateVdsGroupCommand, both are indeed
>updateble. There are limitations - you can't go to a lower version from a
>higher version, you can't change CPU if there are hosts in the cluster. But
>generally - yes, they both are updateble
Line 621: optionalArguments: {cluster.description: 'xs:string',
cluster.cpu.id: 'xs:string', cluster.version.major: 'xs:int',
cluster.version.minor: 'xs:int',
looks like you're right, changing...
Line 663
wow, it looks like I accidentally deleted this signature... thanks again
Line 694
It existed twice, and in this one there is a type - notice the redundant '}' -
rel=update}.
It's ok, this should be removed
Line 715: case_sensitive: {context: matrix, type: 'xs:boolean', value:
true|false, required: false}
correct, good call
Line 725: datacenter.storage_format: xs:string
the signature appears twice, removing this occurrence (the other occurrence has
empty url params)
Line 1206: hostnic.name: xs:string
according to our code it's possible, seems like in context of bond, take a look
at these lines from BackendHostNicResource-->update():
if(nic.isSetName() && inter.getBonded() != null && inter.getBonded()){
params.setBondName(nic.getName());
}
--
To view, visit http://gerrit.ovirt.org/2619
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c42f9d38b279071a98cc9414a0abba8e532df80
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: [email protected]
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: [email protected]
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
