Yair Zaslavsky has posted comments on this change.
Change subject: core : Adding functionality for moving and coping disks of
vm/templates
......................................................................
Patch Set 5: (5 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java
Line 291: VM vm = getVmDAO().get(getImage().getvm_guid());
Is there no possible scenario in which a wrong vm guid exists?
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyImageGroupCommand.java
Line 120: List<DiskImage> snapshots =
DbFacade.getInstance().getDiskImageDAO()
Didn't you introduce getDiskImageDAO() method that can be used here?
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImagesActionsParametersBase.java
Line 11: private Guid imageId = Guid.Empty;
Basically, the same as before (as new Guid() allocates with the "EMPTY" guid as
value) )
Maybe you want to do this in a separate cleanup patch?
....................................................
File
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
Line 81: USER_COPIED_TEMPLATE_DISK=User ${UserName} coping template disk to
domain ${StorageDomainName}.
Is it starting to copy here?
Anyway, you have a typo - should be copying, not coping.
Line 88: USER_MOVED_VM_DISK_FINISHED_FAILURE=User ${UserName} finished with
failure to move a disk to domain ${StorageDomainName}.
How about ${UserName} has failed to move a disk to domain
--
To view, visit http://gerrit.ovirt.org/2555
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief57abf659e012d73226f8d68211d3832fe2f036
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
