Omer Frenkel has posted comments on this change.
Change subject: core : Adding functionality for moving and coping disks of
vm/templates
......................................................................
Patch Set 6: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java
Line 61: && validateDestStorage(canDoActionMessages)
i think isSourceAndDestTheSame() should come after validateSourceStorageDomain
and validateDestStorage because the domains params may be null
Line 244: public List<PermissionSubject> getPermissionCheckSubjects() {
permission should be on template/vm, on the storage we need to check quota (i
guess in later patch)
Line 290: } else if (!Guid.Empty.equals(getImage().getvm_guid())) {
if its empty shouldn't we return false?
Line 291: VM vm = getVmDAO().get(getImage().getvm_guid());
why not check if the vm is null?
--
To view, visit http://gerrit.ovirt.org/2555
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief57abf659e012d73226f8d68211d3832fe2f036
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
