Doron Fediuck has posted comments on this change. Change subject: core: Remove pubkey2ssh ......................................................................
Patch Set 1: (2 inline comments) Juan, I have parts of you code implemented elsewhere. It seems that we can improve by reusing SSH-related functions. Please see inline & let me know what you think of it. Also, we'll eventually need Ofer's help to verify it. .................................................... File backend/manager/modules/engineencryptutils/src/main/java/org/ovirt/engine/core/engineencryptutils/StoreUtils.java Line 118: This part would be easier to read if you use something like: byte[] bData = "ssh-rsa".getBytes(); Line 142: WRT to length entries for exponent and modulus, AFAIR it should be written as DWORD. I wrote it already in- backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/HostKeyVerifier.java I think it will be wiser to concentrate SSH encoding / decoding in one place, so if we have a bug we can fix it once... Do you think it would be better to refactor and re-use HostKeyVerifier.java? -- To view, visit http://gerrit.ovirt.org/3138 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea3223e58299a84a82391fdd134e43b89750ef4b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
