Juan Hernandez has posted comments on this change. Change subject: core: Remove pubkey2ssh ......................................................................
Patch Set 1: (2 inline comments) See my responses inline. I will review your code and refactor this change accordingly. .................................................... File backend/manager/modules/engineencryptutils/src/main/java/org/ovirt/engine/core/engineencryptutils/StoreUtils.java Line 118: Indeed, I just blindly copied it from the .c version, but you are right, it looks like it is the length of the "ssh-rsa" string (7 bytes) followed by the "ssh-rsa" string. Line 142: I don't see any reason not to reuse what is already done. I will change this. However it is maybe worth extracting that common logic to an utility class/method, something like SSHUtils. -- To view, visit http://gerrit.ovirt.org/3138 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea3223e58299a84a82391fdd134e43b89750ef4b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
