Yair Zaslavsky has posted comments on this change.
Change subject: core: Allowing path configuration of log4j for engine-config
(#790443)
......................................................................
Patch Set 3: (2 inline comments)
....................................................
File
backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/EngineConfigLogic.java
Line 84: private Collection<String> getPossibleLog4ConfPaths() {
My bad :) This is what happens when you give your methods "short" names :)
Done.
Line 85: return Arrays.asList(appConfig.getString(LOG4J_CONF_PATH_KEY,
DEFAULT_LOG4J_CONF_PATH), DEFAULT_LOG4J_CONF_PATH);
No.
If the key exists, the file may still not exist , and in this case, I would
still like to check a file for the value of DEFAULT_LOG4J_CONF_PATH.
--
To view, visit http://gerrit.ovirt.org/3366
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I55ff4bb816ba15bddb755a5bbe2ccfaf24b792a0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
