Doron Fediuck has posted comments on this change. Change subject: core: Allowing path configuration of log4j for engine-config (#790443) ......................................................................
Patch Set 4: (1 inline comment) See inline remark- unsure we need more than one naming convention. Also, please check the jenkins failure. .................................................... File backend/manager/tools/engine-config/src/main/resources/engine-config.conf Line 7: log4j.conf.path=/etc/ovirt-engine/engine-config/log4j.xml This is introducing new naming convention. Is it on purpose? Why not log4jConfPath? -- To view, visit http://gerrit.ovirt.org/3366 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I55ff4bb816ba15bddb755a5bbe2ccfaf24b792a0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
