Yair Zaslavsky has posted comments on this change. Change subject: core: adding ValidateSession query + servlet ......................................................................
Patch Set 6: Looks good to me, but someone else must approve (1 inline comment) Minor comment, looks good besides that. Talk to Allon about the query issue (I wonder if the reports servlet should be treated as user portal, he will explain you more on this issue). .................................................... File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ValidateSessionQueryTest.java Line 23: Assert.assertTrue(query.getQueryReturnValue().getSucceeded()); Can you import static Assert? -- To view, visit http://gerrit.ovirt.org/3338 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I250628c78e48bc5eec0fd725e12878bef5e1cb8c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
