Allon Mureinik has posted comments on this change.

Change subject: core: adding ValidateSession query + servlet
......................................................................


Patch Set 6: (2 inline comments)

basically looks good, some minor issues.

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ValidateSessionQuery.java
Line 40:     protected Object getSessionUser(String sessionID) {
Use SessionDataContainer.getInstance().getUser(sessionID)

Line 43: 
why not final?

--
To view, visit http://gerrit.ovirt.org/3338
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I250628c78e48bc5eec0fd725e12878bef5e1cb8c
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to