Yair Zaslavsky has posted comments on this change.

Change subject: engine : Updated user information in OpenLDAP are not 
propagated to engine
......................................................................


Patch Set 2:

(1 comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java
Line 166:             Map<String, Map<Guid, DbUser>> userByDomains = new 
HashMap<String, Map<Guid, DbUser>>();
Line 167: 
Line 168:             // Filter all users by domains
Line 169:             for (DbUser user : filteredUsers) {
Line 170:                 dbUserMap.put(user.getId(), user);
Hi, this is why in the my general comment i asked you to check with Ondra if 
reproduced on other vendors. I have a feeling this is a general bug, not 
open-ldap specific.
Line 171:                 Map<Guid, DbUser> domainUser;
Line 172:                 if (!userByDomains.containsKey(user.getDomain())) {
Line 173:                     domainUser = new HashMap<Guid, DbUser>();
Line 174:                     userByDomains.put(user.getDomain(), domainUser);


-- 
To view, visit http://gerrit.ovirt.org/18886
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie011829e189e36bebfa2c06959b1c8a2e2038cbc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to