Yair Zaslavsky has posted comments on this change.

Change subject: engine : Updated user information in OpenLDAP are not 
propagated to engine
......................................................................


Patch Set 2:

(1 comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/OpenLdapGuidEncoder.java
Line 21:         DbUser user = 
DbUserCacheManager.getInstance().getDbUserByUserId(guid);
Line 22:         if (user == null) {
Line 23:             return guid.toString();
Line 24:         }
Line 25:         return getUserName(user.getLoginName());
But arent we using the encoder on entryUUID andn ot on uid?
Line 26:     }
Line 27: 
Line 28:     private String getUserName(String loginName) {
Line 29:         int index = loginName.indexOf("@");


-- 
To view, visit http://gerrit.ovirt.org/18886
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie011829e189e36bebfa2c06959b1c8a2e2038cbc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to