Allon Mureinik has posted comments on this change.
Change subject: backend,frontend: reduce ExportRepoImage parameters
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportRepoImageCommand.java
Line 194: if (!validate(new
StorageDomainValidator(getStorageDomain()).isDomainExistAndActive())) {
Line 195: return false;
Line 196: }
Line 197: } catch (Exception e) {
Line 198: e.printStackTrace();
this will pring to stderr - not really a robust approach.
Besides, what exception can you get here? An NPE?
Line 199: }
Line 200:
Line 201: // At the moment it's not possible to export images that have
a snapshot
Line 202: // or that are based on a a template.
--
To view, visit http://gerrit.ovirt.org/18884
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I166b19b9d69077da8e9ba4cb0d63fd31fdd4e45d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
