Allon Mureinik has submitted this change and it was merged.

Change subject: backend,frontend: reduce ExportRepoImage parameters
......................................................................


backend,frontend: reduce ExportRepoImage parameters

In this patch:
* reduce the number of required parameters for ExportRepoImageCommand
  to imageGroupId and destinationDomainId
* switch from StoragePoolValidator to StorageDomainValidator in the
  canDoAction (to handle also the domain in maintenance case)
* update the ExportRepoImage tests
* update the serialVersionUID for ExportRepoImageParameters as it was
  already in use by ImportRepoImageParameters

Change-Id: I166b19b9d69077da8e9ba4cb0d63fd31fdd4e45d
Signed-off-by: Federico Simoncelli <[email protected]>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportRepoImageCommand.java
M 
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ExportRepoImageCommandTest.java
M 
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportExportRepoImageCommandTest.java
M 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ExportRepoImageParameters.java
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/ExportRepoImageModel.java
5 files changed, 69 insertions(+), 48 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/18884
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I166b19b9d69077da8e9ba4cb0d63fd31fdd4e45d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to