Allon Mureinik has submitted this change and it was merged. Change subject: core: Introducing VersionStorageFormatUtil ......................................................................
core: Introducing VersionStorageFormatUtil Introduced a new utility class, VersionStorageFormatUtil, to handle the relationship between Version and StorageFormatType. This patch includes the following: 1. The new VersionStorageFormatUtil class. 2. A test case for this class. 3. Refactoring UpdateStoragePoolCommand to use this new class. 4. Refactoring AddStoragePoolWithStoragesCommand to use this new class. Note that a side benefit of changes (3) and (4) is future-proofing these commands in a way that if a future version will introduce storage format V4, these classes won't have to be touched. Change-Id: I47fb8b14e5c97b601c8fc0cc296a4ec42a48227a Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStoragePoolWithStoragesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VersionStorageFormatUtil.java A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/VersionStorageFormatUtilTest.java 4 files changed, 57 insertions(+), 18 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18697 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I47fb8b14e5c97b601c8fc0cc296a4ec42a48227a Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
