Allon Mureinik has posted comments on this change.
Change subject: core: Introducing VersionStorageFormatUtil
......................................................................
Patch Set 3:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStoragePoolWithStoragesCommand.java
Line 154: }
Line 155: final StorageDomainStatic staticDomain =
storageDomain.getStorageStaticData();
Line 156: boolean staticDomainChanged = false;
Line 157: // for data centers >= 3.1 we enforce the
domain version to V3
Line 158: // this strictly needs to be before selecting
the masterStorageDomain because the pool master
will do
Line 159: // version (setmaster_domain_version) depends
on the domain upgrade.
Line 160: StorageFormatType requiredFormatType =
Line 161:
VersionStorageFormatUtil.getFormatForVersion(getStoragePool().getcompatibility_version());
Line 162: if (staticDomain.getStorageFormat() !=
requiredFormatType) {
Line 157: // for data centers >= 3.1 we enforce the
domain version to V3
Line 158: // this strictly needs to be before selecting
the masterStorageDomain because the pool master
Line 159: // version (setmaster_domain_version) depends
on the domain upgrade.
Line 160: StorageFormatType requiredFormatType =
Line 161:
VersionStorageFormatUtil.getFormatForVersion(getStoragePool().getcompatibility_version());
Indeed - intended.
This way, you avoid all sorts of untested, unsupported, mutations like a 2.2 DC
on storage V3.
Line 162: if (staticDomain.getStorageFormat() !=
requiredFormatType) {
Line 163: if (!staticDomainChanged) {
Line 164:
getCompensationContext().snapshotEntity(staticDomain);
Line 165: }
--
To view, visit http://gerrit.ovirt.org/18697
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I47fb8b14e5c97b601c8fc0cc296a4ec42a48227a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
