mooli tayer has posted comments on this change.

Change subject: engine: application touches a file to detect un orderly shutdown
......................................................................


Patch Set 1:

(1 comment)

....................................................
File pom.xml
Line 139:         <groupId>commons-httpclient</groupId>
Line 140:         <artifactId>commons-httpclient</artifactId>
Line 141:         <version>${httpclient.version}</version>
Line 142:       </dependency>
Line 143:         <dependency>
Using FileUtils my code became cleaner 
(I wanted to update ts if file exists, and get similar exception when file 
cannot get created or deleted)
I thinks this is a dependency worth having (seem other places that can benefit 
from it) and it is already contained in our container (under 
$JBOSS_HOME/modules)

What do you say?
Line 144:         <groupId>commons-io</groupId>
Line 145:         <artifactId>commons-io</artifactId>
Line 146:         <version>${commons-io.version}</version>
Line 147:       </dependency>


-- 
To view, visit http://gerrit.ovirt.org/19102
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8de64637299e7932a5a2761c7bb495373c418aa
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: mooli tayer <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to