Yaniv Bronhaim has posted comments on this change.

Change subject: engine: application touches a file to detect un orderly shutdown
......................................................................


Patch Set 10: Code-Review+1

(1 comment)

....................................................
File 
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/EngineLocalConfig.java
Line 209:     public String getPKIEngineStoreAlias() {
Line 210:         return getProperty("ENGINE_PKI_ENGINE_STORE_ALIAS");
Line 211:     }
Line 212: 
Line 213:     public File getEngineUpMark(){
i would call it getEngineUpMarkFile
Line 214:         return getFile("ENGINE_UP_MARK");
Line 215:     }


-- 
To view, visit http://gerrit.ovirt.org/19102
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8de64637299e7932a5a2761c7bb495373c418aa
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: mooli tayer <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to