Lior Vernia has posted comments on this change.
Change subject: webadmin,userportal: do not add default nic on edit vm
......................................................................
Patch Set 4:
(2 comments)
One meaningful comment.
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java
Line 262: public void onSuccess(Object model, Object result) {
Line 263: initNetworkInterfaces(networkBehavior,
(List<VmNetworkInterface>) result);
Line 264: }
Line 265: };
Line 266: AsyncDataProvider.getVmNicList(getVmNicsQuery, vm.getId());
As far as I understand the VM NICs shouldn't change when the DC/cluster
selection changes, so this code should probably not be called from
postDataCenterWithClusterItemChanged() but perhaps from the constructor.
What will need to be called here (again, if I understand correctly) is just the
inner initNetworkInterfaces() method, because the profile list should change so
the profile assignment will probably be different.
Line 267: }
Line 268:
Line 269: @Override
Line 270: protected void changeDefualtHost()
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
Line 1009: AsyncQuery query = new AsyncQuery(this, new
INewAsyncCallback() {
Line 1010:
Line 1011: @Override
Line 1012: public void onSuccess(Object model, Object returnValue) {
Line 1013: doInitNetworkInterfaces(behavior, nics,
(List<VnicProfileView>) returnValue);
Indentation isn't right.
Line 1014: }
Line 1015:
Line 1016: });
Line 1017:
--
To view, visit http://gerrit.ovirt.org/17315
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I21724b30dc1ad6ccbbe40448ad77c47c22123c06
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
