Lior Vernia has posted comments on this change.
Change subject: webadmin,userportal: do not add default nic on edit vm
......................................................................
Patch Set 4:
(1 comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java
Line 262: public void onSuccess(Object model, Object result) {
Line 263: initNetworkInterfaces(networkBehavior,
(List<VmNetworkInterface>) result);
Line 264: }
Line 265: };
Line 266: AsyncDataProvider.getVmNicList(getVmNicsQuery, vm.getId());
Wasn't it cached in the beginning so far? Using the networkInterfacesInitied
variable? To preserve the existing behavior without using
networkInterfacesInitied, the call to initNetworkInterfaces() should be moved
somewhere it's only called once.
And if updating the profiles according to the choice of DC/cluster is out of
the scope of this patch, then nothing should be added to
postDataCenterWithClusterSelectedItemChanged() instead of the call to
initNetworkInterfaces() that was moved elsewhere.
Line 267: }
Line 268:
Line 269: @Override
Line 270: protected void changeDefualtHost()
--
To view, visit http://gerrit.ovirt.org/17315
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I21724b30dc1ad6ccbbe40448ad77c47c22123c06
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
