Omer Frenkel has posted comments on this change. Change subject: core, webadmin, restapi: Detach password from VdcUser ......................................................................
Patch Set 3: (1 comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmLogonCommand.java Line 40: final VM vm = getVm(); Line 41: Line 42: // Send the log on command to the virtual machine: Line 43: final VdcUser currentUser = getCurrentUser(); Line 44: final String password = SessionDataContainer.getInstance().getPassword(); maybe add a null check that will return empty string to comply with old code? or its safe for password to be null here? Line 45: final String domainController = currentUser != null ? currentUser.getDomainControler() : ""; Line 46: final boolean sentToVM = Backend Line 47: .getInstance() Line 48: .getResourceManager() -- To view, visit http://gerrit.ovirt.org/17096 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ab9321816ee28355a4118910086891f5a552014 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
